soc-pe-bot
commented
5 months ago Team's Response
We believe this is a duplicate of #148 as it is caused by the same issue, allowing the book title to be edited into special characters or just a number without exception though the normal add feature and UG does not allow so, and can thus be fixed by fixing #148 as well. Furthermore, this crash will ONLY happen if the special character is a very specific special character (such as question marks as shown above), and not for all special characters - a "!" will not crash the app, for example, due to Java issues that are out of our control.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Able to edit book title to contain special characters
As seen in the screenshot below, when I try to add a book '$$dollar' it shows an error due to special characters. However, when i try to edit the book title of an exiting book to '$$dollar' it proceeds and edits the name
[original: nus-cs2113-AY2324S2/pe-interim#134] [original labels: type.FeatureFlaw severity.Medium]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
Thank you for your response. We accept this issue as we should have put an exception to disallow users from editing book titles to special characters.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [x] I disagree
Reason for disagreement: I dont think this is a duplicate of #148 but perhaps another issue? Reason because I can still edit the title of the book and add a special character through the txt file and I can still achieve the same outcome. I suspect that this can be solved individually through the parsing class. I have attached a screenshot to show the reason and credits to ChatGPT! Furthermore, there are other symbols that can cause it to crash such as +, *. (can search up on meta characters, i think most if not all would cause it to crash)
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
As seen in the screenshot, the program crashes. I think this happens when the book title is has a special character followed by a space and some words. E.g. '?? Yes"