search

HenriAugusto / completion-plugin

Completion for Pure Data
BSD 3-Clause "New" or "Revised" License
19 stars 1 forks source link

Search all file extensions other than pd_darwin, pd_linux and dll #36

Closed tomoyanonymous closed 1 year ago

tomoyanonymous commented 3 years ago

This PR adds the feature that searches external with file types other than pd_darwin, pd_linux, and dll.

According to https://github.com/pure-data/externals-howto#library , external files can be architecture-specific and they will be distinguished by file extensions. In fact, external objects in else library for macOS are shipped with *.d_fat and they could not be found with the current completion.

Currently tested only on macOS but I think it will work on other OSs...

porres commented 1 year ago

hi, this project seems a bit dead to me :) I could release a new version in my fork and take this

porres commented 1 year ago

uploaded a new version here https://github.com/porres/completion-plugin

@tomoyanonymous I hope you can help me with more improvements. Like, now if we scan for ELSE externals we get two equal entries for sfont~ because there are two separate binaries one for each architecture, hence, this change of yours may lead to duplicate names and we need a way to filter these repetitions.

tomoyanonymous commented 1 year ago

@porres Thanks for forking the project. I just found the way to solve the duplication problem with a tiny fix. I'll send PR to your repo soon.

porres commented 1 year ago

I'll send PR to your repo soo

great, I guess I should create a new repo from scratch and you can fork from me :)