search

HenriAugusto / completion-plugin

Completion for Pure Data
BSD 3-Clause "New" or "Revised" License
19 stars 1 forks source link

overwritten pdtk_text_editing breaks another plugin #38

Open RVirmoors opened 2 years ago

RVirmoors commented 2 years ago

hi! great work on this plugin, cheers

i'm working on a simple plugin with key bindings: https://github.com/RVirmoors/maxhotkey-pd

the problem is, my bindings (e.g. N for a new object box) work just once, before this plugin overwrites the pdtk_text_editing proc

now, a quick and dirty fix is to just add pdtk_text_editing_old $mytoplevel $tag $editing at the end of your pdtk_text_editing

not sure if: a) this breaks things (only tested it for a couple of minutes) b) it's inefficient c) there's maybe a way for me to hook into your proc from my plugin, so that yours doesn't need to be modified

i'd obviously appreciate the expertise of people better at tcl than me here

porres commented 1 year ago

can we move this to https://github.com/porres/completion-plugin/issues ?

not that I am an expert, but maybe @umlaeute can help

umlaeute commented 1 year ago

For moving issues between repositories you need someone who has serious powers (can't remember, probably "admin") in both repositories...

porres commented 1 year ago

I thought maybe opening a new one over there would do it :)

umlaeute commented 1 year ago

then i'm not sure why you pinged me...

porres commented 1 year ago

then i'm not sure why you pinged me...

to help with your expertise

not sure if: a) this breaks things (only tested it for a couple of minutes) b) it's inefficient c) there's maybe a way for me to hook into your proc from my plugin, so that yours doesn't need to be modified

I can't answer this :(