search

HenriDellal / emerald

Simple and customizable launcher for Android
GNU General Public License v3.0
83 stars 18 forks source link

Spanish translation #95

Closed ivanhercaz closed 5 years ago

ivanhercaz commented 6 years ago

Hi @HenriDellal, First of all, thank you to you and to all the contributors of Emeral for this awesome, easy to use and minimalistic launcher. Well, I wanted to contribute to this project with a new translation to Spanish.

I translated all the files I understand they are translatable, because there are another files without text to translate. The files translated are:

I have one suggestion too: why the last string in strings.xml is untranslatable? It is easy to translate and if we translate it we could make easier to share with everyone the contributions of each one and to encourage users to "Want to help? Report bugs and submit suggestions via...". What do you think about it?

HenriDellal commented 6 years ago

Hello. Thank you very much for help, going to merge the PR soon. The text on about screen is not for translation yet, though I'd like to make it translatable in the future. The reason is that I'd like to change the about screen UI and move information about contributors into arrays.xml so it's easier to maintain translations.

ivanhercaz commented 6 years ago

All right! Good idea. So I am not going to add the about translation in this PR and when you have made the improvement, I will translate it.

ivanhercaz commented 5 years ago

@HenriDellal, if you prefer I can review again the code to clean it of the strings with translatable parameter set to false. I could avoid you time to review the strings.

HenriDellal commented 5 years ago

Thank you. I will do it myself, have to review the translation anyway.

ivanhercaz commented 5 years ago

Nice! I am happy to see this PR merged. Excuse me for the extra work you did due I didn't know some things about the translations of Android apps.

Thank you for this app, your work and your help!

Sent from my Moto X Play using FastHub-Libre

HenriDellal commented 5 years ago

Everything is fine, no need to apologize. Thanks!