Henrik-3 / unofficial-valorant-api

Unofficial VALORANT API using the VALORANT Ingame API
442 stars 19 forks source link

C# NSwag openapi/swagger generator conflict between player's Economy and round's playerstats' economy #44

Closed M-U-X closed 2 years ago

M-U-X commented 2 years ago

C# NSwag openapi/swagger generator conflict between player's Economy and round's playerstats' economy, the structure of a player's economy in a match details, is spent {overall, average} loadout {overall, average} and in the round's playerstats is: spent: int, loadout:int the generator uses the same structure for both since they have the same name "Economy", I don't know if that's an issue/limitation of the generator (unlikely) or an ambiguity of the openapi definitions of your API

M-U-X commented 2 years ago

Checking the swagger definition of the api, it's indeed an error on your part, economy: type: object properties: spent: type: string properties: overall: type: integer example: 59750 average: type: integer example: 2598 loadout_value: type: object properties: overall: type: integer example: 71700 average: type: integer example: 3117 the type of spent is defined as string instead of object

Henrik-3 commented 2 years ago

Should be fixed with v2.0.2