search

HenrikBengtsson / R.matlab

R package: R.matlab
https://cran.r-project.org/package=R.matlab
86 stars 25 forks source link

Recognize v7.3 mat files and suggest alternative #22

Closed zeehio closed 9 years ago

zeehio commented 9 years ago

I would say this is a valid starting point for issue #20.

Instead of manually parsing the H5 superblock, I opted for using the h5::is.h5file. I believe using the h5 package is a more simple and robust solution than writing a function to parse the HDF5 files. If you prefer to parse the H5 superblock, feel free to reject this patch.

Best,

HenrikBengtsson commented 9 years ago

Thank you for trying to solve the problem of detecting MAT 7.3 files and giving information error messages that they are (yet) not supported. Unfortunately, the design requirements of R.matlab does not allow us to do it making use of h5. Please see Issue #23 for more details.

Because of #23, I'm closing this PR.

PS/FYI. The reason for Travis CI/AppVeyor giving errors is that the corresponding config files needs to be updated such that they also install h5. Those files can be updated by running make config.

HenrikBengtsson commented 8 years ago

FYI, MAT v7.3 files are now detected by readMat() and an informative error message is given if read. For more details, see Issue #23.