search

HenrikBengtsson / affxparser

🔬 R package: This is the Bioconductor devel version of the affxparser package.
http://bioconductor.org/packages/devel/bioc/html/affxparser.html
7 stars 3 forks source link

Update _mingw.h for the 4.9.3 toolchain #24

Closed jimhester closed 8 years ago

jimhester commented 8 years ago

This fixes #22 (whose title should be 4.9.3 BTW).

I updated the included _mingw.h file to the one in Rtools/mingw_32/i686-w64-mingw32/include/_mingw.h with the following diff

--- /c/Rtools33/mingw_32/i686-w64-mingw32/include/_mingw.h      2015-09-22 11:35:06.000000000 -0400
+++ _mingw.h    2016-04-04 13:46:45.427504400 -0400
@@ -74,7 +74,7 @@
 #endif /* __GNUC__ */

 #ifdef _MSC_VER
-#define USE___UUIDOF   1
+#define USE___UUIDOF   0
 #else
 #define USE___UUIDOF   0
 #endif

Which allowed affxparser to compile without errors on the new toolchain.

Needing to embed a static header in the source seems prone to breakage in the future, maybe the makefile should copy _mingw.h from the Rtools include directory and apply the appropriate patch or some other mechanism used to work around the UUID issue.