UCRT patch from Tomas Kalibra

[kasperdanielhansen]

This is required for R 4.2. I should have dealt with this months ago; autopatching stops tomorrow.

Tomas writes (as of today)

For "affxparser", the package includes a copy of some internal MinGW header, I read originating from Henrik. There should be a cleaner way, but my patch does it the same way, replacing with the content for the new MinGW in the toolchain. It will almost surely not work with older MinGW (older toolchains), so your package would on Windows require R 4.2. If that is ok, perhaps you can add the patch now but then look for a cleaner solution, which doesn't depend on a specific version of MinGW.

[HenrikBengtsson]

... so your package would on Windows require R 4.2.

I've added new GitHub Actions tests for MS Windows, and it looks like this patch works with R 4.0 (oldrel), 4.1 (release), and 4.2 (devel), but it does not work with R (<= 3.6). See https://github.com/HenrikBengtsson/affxparser/runs/5667725231?check_suite_focus=true.

This is better than anticipated, so I'll go ahead a push this to Bioc devel.

[kasperdanielhansen]

Thanks

On Wed, Mar 23, 2022 at 6:05 PM Henrik Bengtsson @.***> wrote:

... so your package would on Windows require R 4.2.

I've added new GitHub Actions tests for MS Windows, and it looks like this patch works with R 4.0 (oldrel), 4.1 (release), and 4.2 (devel), but it does not work with R (<= 3.6). See https://github.com/HenrikBengtsson/affxparser/runs/5667725231?check_suite_focus=true .

This is better than anticipated, so I'll go ahead a push this to Bioc devel.

— Reply to this email directly, view it on GitHub https://github.com/HenrikBengtsson/affxparser/pull/37#issuecomment-1076865362, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABF2DH4UQQFZSGXS5476TU3VBOIQ3ANCNFSM5Q2PTBYQ . You are receiving this because you authored the thread.Message ID: @.***>

-- Best, Kasper