search

HenrikBengtsson / matrixStats

R package: Methods that Apply to Rows and Columns of Matrices (and to Vectors)
https://cran.r-project.org/package=matrixStats
203 stars 33 forks source link

Fix issue #172 #194

Closed const-ae closed 3 years ago

const-ae commented 3 years ago

I wasn't quite sure what kind if tests, you usually apply in this context. I just opted to print the result to make sure the calculation succeeded, but I can replace those print statements with a more meaningful check.

HenrikBengtsson commented 3 years ago

Yes, please. If you can also validate that it returns what it should, that would add additional protection against future mistakes.

codecov-io commented 3 years ago

Codecov Report

Merging #194 (93d2614) into develop (c7945ed) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #194   +/-   ##
========================================
  Coverage    88.48%   88.48%           
========================================
  Files          110      110           
  Lines         4368     4368           
========================================
  Hits          3865     3865           
  Misses         503      503
Impacted Files Coverage Δ
R/rowAvgsPerColSet.R 78.78% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9339fa7...93d2614. Read the comment docs.