search

HenrikBengtsson / matrixStats

R package: Methods that Apply to Rows and Columns of Matrices (and to Vectors)
https://cran.r-project.org/package=matrixStats
202 stars 33 forks source link

CLEANUP: Deprecated anyMissing(), colAnyMissings(), and rowAnyMissings() #243

Open HenrikBengtsson opened 8 months ago

HenrikBengtsson commented 8 months ago

anyMissing(), colAnyMissings(), and rowAnyMissings() are superseeded by base::anyNA(), colAnyNAs(), and rowAnyNAs() since way back.

HenrikBengtsson commented 8 months ago

anyNA() was added in R 3.1.0. This package supports R (>= 2.12.0), so if we want to keep that support, we need a plan for that too.

PeteHaitch commented 8 months ago

FWIW I've deprecated (BioC 3.18) and made defunct (BioC 3.19) the implementations of colAnyMissings() and rowAnyMissings() in DelayedMatrixStats. It never had a anyMissing() implementation.

We opted to not implement colAnyMissings(), rowAnyMissings(), and anyMisisng() generics when we made MatrixGenerics, following the note in matrixStats that these were no longer recommended and may be removed in future versions.

HenrikBengtsson commented 7 months ago

Action plan:

HenrikBengtsson commented 7 months ago

Actually, anyMissing() takes argument idxs too, so, I guess we should keep it for now and only deprecated the row- and col- versions.