search

HenrikBengtsson / profmem

🔧 R package: profmem - Simple Memory Profiling for R
https://cran.r-project.org/package=profmem
35 stars 2 forks source link

ROBUSTNESS: Add explicit 'stringsAsFactors' arguments [cbind, rbind] #18

Closed HenrikBengtsson closed 4 years ago

HenrikBengtsson commented 4 years ago 
$ for pkg in $pkgs; do echo "$pkg:"; (cd "$pkg"; grep -E "^[ \t]*[^#].*[cr]bind" -- */*.R | grep -vF stringsAsFactors;); echo; read -r -p "Press ENTER to continue ..."; done

profmem:
R/Rprofmem-class.R:  data <- rbind(data, list(what = "", bytes = total, calls = ""))
HenrikBengtsson commented 4 years ago

stringsAsFactors() has no effect here, e.g.

> str(rbind(data.frame(), list(a=4:5, b=letters[4:5])))
'data.frame':   2 obs. of  2 variables:
 $ a: int  4 5
 $ b: chr  "d" "e"

and

> data <- data.frame(a=1:3, b=letters[1:3], stringsAsFactors=F)
> str(rbind(data, list(a=4:5, b=letters[4:5])))
'data.frame':   5 obs. of  2 variables:
 $ a: int  1 2 3 4 5
 $ b: chr  "a" "b" "c" "d" ...