search

HenrikBengtsson / speedtest-cli-extras

:signal_strength: Tools to enhance the speedtest-cli network tools
120 stars 32 forks source link

Minor bash script issues #3

Closed hamiltont closed 10 years ago

hamiltont commented 10 years ago

Very useful extras. Here's some minor issues:

You need the shebang #!/usr/bin/env bash to be the first line to be effective

Also, if you rename it to speedtest-csv.sh then github will colorize the bash when you look at it, whihc is minorly useful.

Finally, I had to mark the script executable before it could be run. Git can remember this file mode, so if you mark it as executable then commit that change no one else would have to do this

HenrikBengtsson commented 10 years ago

It Turns out that solving Issue #3(c) solved Issue #3(b). From trial and error (couldn't find a reference for this), I found that if GItHub cannot infer the file type from the extension, it checks whether the file is executable or not and enables syntax highlighting based on that. I don't know if it then also looks at the shebang do decide on language or not.