search

HenrikJoreteg / emoji-images

replace stuff like :heart: with <img> tags of corresponding images per: http://www.emoji-cheat-sheet.com/
173 stars 29 forks source link

can emoji ignore <code> and <pre> tags #2

Closed akhoury closed 10 years ago

akhoury commented 10 years ago

without a huge performance hit? Thanks

HenrikJoreteg commented 10 years ago

I feel like it's a bit out of scope for what this is intended for which is usually taking a string from user input, not existing HTML, and running it through this. So, I don't feel like the assumption that you don't want it to do anything in a <code> tag should be made in this core module. If it's something you need for your project, I would say just fork this repo and add it there.

Thanks for the suggestion, though.

julianlam commented 10 years ago

The annoying part is that there's no easy way to select code "ouside" of <code><pre> blocks.