search

HenrikJoreteg / hjs-webpack

Helpers/presets for setting up webpack with hotloading react and ES6(2015) using Babel.
1.79k stars 127 forks source link

Webpack 2 support #318

Closed selbekk closed 7 years ago

selbekk commented 7 years ago

This pull request adds support for webpack 2 configs instead of the deprecated 1.x version.

Still a bit rough around the edges code style wise, but it looks like it's working quite nice.

Very open to suggestions as well as criticism - this might be my largest PR to OSS to date :)

Fixes #295

ivarni commented 7 years ago

I can probably help out with some end-user testing this weekend

Edit: Tested it with a few of my hobby projects and didn't run into any problems.

selbekk commented 7 years ago

When do you think you'll have time to have a look @HenrikJoreteg?

Benvorth commented 7 years ago

+1

HenrikJoreteg commented 7 years ago

@selbekk thanks for tackling this! Upon visual review of the code it all makes sense and looks great. I've been too busy to do much with OSS in the past year, but the last thing I want to do is be a blocker, so I'd much rather add contributors to get myself out of the way. I went ahead and added you as a contributor, I'd say feel free to merge this yourself.

My only caveat is that since @lukekarrys has been doing much of the maintenance here, it'd be great to get a +1 from him. But as far as I'm concerned 🚢 it!

lukekarrys commented 7 years ago

Yes, please :shipit:! I've very much fallen behind on this repo, so I'm definitely happy to have a few more contributors. Thanks for all the work on this @selbekk!

I'd say merge and publish to npm! Just for reference I usually use the np package to publish this to npm, but whatever works.

Thanks again!

HenrikJoreteg commented 7 years ago

@lukekarrys awesome, I added you as a contributor on npm too @selbekk. Happy publishing!

selbekk commented 7 years ago

Awthanks you guys - hugely appreciate it. I'll get on with merging this tonight then :)