search

HenrikJoreteg / hjs-webpack

Helpers/presets for setting up webpack with hotloading react and ES6(2015) using Babel.
1.79k stars 129 forks source link

Use prettier for formatting #324

Open selbekk opened 7 years ago

selbekk commented 7 years ago

One thing that bothered me a bit when I created my first PR was that I used a VERY different code style than the original author (sorry @HenrikJoreteg - still love you!). prettier fixes code style on commit (or on save through some editor plugins), which would probably be a great help for future contributors (and myself).

I'm totally for discussing the rules I set up though, so please give me some feedback =)

HenrikJoreteg commented 7 years ago

No need to apologize :)

My main feeling on formatting is that I don't like spending time discussing it, lol. Honestly if there's some consensus for something else i guess that's fine. But unless there's compelling reason to move away from standard, I'd rather not, personally, but I'm also not the one doing maintenance on this right now so... /me shrugs.

selbekk commented 7 years ago

@HenrikJoreteg the beauty of prettier is that it is opinionated as hell and lets us skip that discussion completely. I'll tweak the settings a bit later before merging, to make sure we've hit the right ones.