search

HenrikJoreteg / moonboots

A set of conventions and tools for bundle and serving clientside apps with node.js
159 stars 20 forks source link

Throw on build error if in production mode #53

Closed latentflip closed 9 years ago

latentflip commented 9 years ago

Currently in production mode you'll get a undefined file with nothing in it if there's a build error. It'd be much better to just throw here.

wraithgar commented 9 years ago

Closes #33

HenrikJoreteg commented 9 years ago

yup do it, you've got commit/publish access right?

latentflip commented 9 years ago

Okay, I need to figure out how to get the tests passing to cover this, then I'll commit and merge.

HenrikJoreteg commented 9 years ago

i added you as collaborator and owner on npm

latentflip commented 9 years ago

Okay, fixed the tests. Had to use domains because we're throwing errors asynchronously, which I think is mostly fine for the use-case we discussed yesterday where you just want production to die if the build fails, but we need to use domains to catch them in testing.