search

HenrikJoreteg / redux-bundler

Compose a Redux store out of smaller bundles of functionality.
https://reduxbundler.com
583 stars 46 forks source link

Integrate redux devtools extension #16

Closed aulneau closed 6 years ago

aulneau commented 6 years ago

So I played around with this a bit and when using the compose redux devtools portion, it seemed to have been overwriting our modified store. I'm using the basic __REDUX_DEVTOOLS_EXTENSION__ here and it seems to be fully functional! screen shot 2018-04-12 at 3 20 19 pm

HenrikJoreteg commented 6 years ago

@aulneau sorry I've been a bit busy, thanks for doing this, it looks great. I'll review/merge this week.

aulneau commented 6 years ago

np! congrats on the book! :)

HenrikJoreteg commented 6 years ago

@aulneau I just realized tests will fail right now in environments where the conditional check fails since null isn't a function that can be composed.

I think it has to be:

  HAS_WINDOW &&
  window.__REDUX_DEVTOOLS_EXTENSION__ &&
  (HAS_DEBUG_FLAG || !IS_PROD)
    ? window.__REDUX_DEVTOOLS_EXTENSION__()
    : a => a
HenrikJoreteg commented 6 years ago

Also, I added CI so the next push to this branch should (hopefully) trigger CircleCI to run.

aulneau commented 6 years ago

ah of course. okay! I fixed that and ran the tests locally and they passed.

HenrikJoreteg commented 6 years ago

Shipped as 21.1.0 thank you @aulneau!