Closed aulneau closed 6 years ago
@aulneau sorry I've been a bit busy, thanks for doing this, it looks great. I'll review/merge this week.
np! congrats on the book! :)
@aulneau I just realized tests will fail right now in environments where the conditional check fails since null
isn't a function that can be composed.
I think it has to be:
HAS_WINDOW &&
window.__REDUX_DEVTOOLS_EXTENSION__ &&
(HAS_DEBUG_FLAG || !IS_PROD)
? window.__REDUX_DEVTOOLS_EXTENSION__()
: a => a
Also, I added CI so the next push to this branch should (hopefully) trigger CircleCI to run.
ah of course. okay! I fixed that and ran the tests locally and they passed.
Shipped as 21.1.0
thank you @aulneau!
So I played around with this a bit and when using the compose redux devtools portion, it seemed to have been overwriting our modified store. I'm using the basic![screen shot 2018-04-12 at 3 20 19 pm](https://user-images.githubusercontent.com/11803153/38702009-123b1772-3e65-11e8-983b-1c202b5d36ed.png)
__REDUX_DEVTOOLS_EXTENSION__
here and it seems to be fully functional!