search

HenrikJoreteg / redux-bundler

Compose a Redux store out of smaller bundles of functionality.
https://reduxbundler.com
583 stars 46 forks source link

When starting an App offline, state of `online` is still `true` #29

Closed layflags closed 6 years ago

layflags commented 6 years ago

https://github.com/HenrikJoreteg/redux-bundler/blob/9591bae010ffb20873ef1279e77f1e757233b6e4/src/bundles/online.js#L9

What about setting the online reducer default state to navigator.onLine?

HenrikJoreteg commented 6 years ago

Oops! Good catch, want to do a PR?

HenrikJoreteg commented 6 years ago

@layflags don't bother with the PR... i'm fixing it right now

HenrikJoreteg commented 6 years ago

fixed via https://github.com/HenrikJoreteg/redux-bundler/commit/ea18ac8e6d254e444d197586a87039814173b494