HenrikJoreteg / redux-bundler

Compose a Redux store out of smaller bundles of functionality.
https://reduxbundler.com
583 stars 46 forks source link

Updates debug logging for SSR #32

Closed aulneau closed 5 years ago

aulneau commented 6 years ago

This PR addresses some of the logging issues I've had when using redux-bundler with something like next.js. should resolve https://github.com/HenrikJoreteg/redux-bundler/issues/24 and https://github.com/HenrikJoreteg/redux-bundler/issues/31

@HenrikJoreteg let me know what you think!

Thanks! t

HenrikJoreteg commented 6 years ago

Hey thanks @aulneau I'm on vacation, just haven't had time to properly review this yet.

aulneau commented 6 years ago

No worries! Enjoy your vacay 👍

aulneau commented 6 years ago

Hey @HenrikJorteg just checking in! Do you think you can review this sometime soon? Thanks!

HenrikJoreteg commented 5 years ago

I ended up re-working the debug bundle, it is not created/configurable programmatically and works in node.js (https://github.com/HenrikJoreteg/redux-bundler/blob/master/docs/misc/changelog.md#change-log).

Thanks for your work on this, i took some of the ideas here (and gave you credit in the change log).

Cheers!

aulneau commented 5 years ago

@HenrikJoreteg Thank you! :D