search

HenrikJoreteg / redux-bundler

Compose a Redux store out of smaller bundles of functionality.
https://reduxbundler.com
583 stars 46 forks source link

Bug missing create selector 67 #68

Closed aaronmccall closed 4 years ago

aaronmccall commented 4 years ago

Closes #67

aaronmccall commented 4 years ago

@HenrikJoreteg, do you think you'll publish this week or next?

HenrikJoreteg commented 4 years ago

Just published 27.0.1... turns out this wasn't quite the whole fix because by not making it external it would have been included twice if you had used redux-bundler and then required create async resource.

Basically, it already bundles "create-selector" so I should have been grabbing it from redux-bundler (which was already external) instead of directly from create-selector. see fix: https://github.com/HenrikJoreteg/redux-bundler/commit/4dd62f905df8bf1e9bc746399449aaef8a0babfa

Anyway... that should fix it. I pulled it into one of my projects and it all seemed ok. Let me know if it doesn't.