search

HenrikJoreteg / redux-bundler

Compose a Redux store out of smaller bundles of functionality.
https://reduxbundler.com
583 stars 46 forks source link

Play nicely with redux-devtools #7

Closed HenrikJoreteg closed 6 years ago

HenrikJoreteg commented 6 years ago

There's a devtools branch showing the level of integration I'd like to support. But... the decorated store idea seems to cause issues for the devtools copose function.

It's possible that if the enhancements to store we make were written as a store enhancer this would just work.

A lot of folks I know don't actually end up using redux devtools often because there's often a router that has conflicting state. For redux-bundler all URL state is handled in redux, which could potentially make the redux time travel debugging work really well with it. So, it'd be cool to get this sorted out.

aulneau commented 6 years ago

I'd love to help out with this! What were the issues specifically that were breaking with regard to integrating dev tools?

HenrikJoreteg commented 6 years ago

@aulneau thanks for your willingness! I didn't spend a lot of time diagnosing it because I don't actually tend to use the redux dev-tools much. So, the first thing that needs to happen is just some investigation, I think.

HenrikJoreteg commented 6 years ago

Completed by @aulneau, merged and shipped in 21.1.0: https://github.com/HenrikJoreteg/redux-bundler/pull/16