HenrikJoreteg / webrtcsupport

Browser module to detect support for WebRTC and extract proper constructors.
55 stars 33 forks source link

removes the assumption that navigator.userAgent matches Chrom(e|ium) #15

Closed fippo closed 9 years ago

fippo commented 9 years ago

@legastero @tommoor

tommoor commented 9 years ago

Heh, was going to do it like this which would leave version undefined rather than false... but honestly, as long as it works :smile:

https://github.com/HenrikJoreteg/webrtcsupport/compare/master...tommoor:master

fippo commented 9 years ago

btw, @xdumaine -- you might hit that too.

Fixed in 2.1.1 and 1.3.1 respectively. Thanks!

tommoor commented 9 years ago

@fippo bad news, sorry :cry: "Uncaught ReferenceError: navіgator is not defined"

fippo commented 9 years ago

grmbl... 2.1.2 and 1.3.2 will be up soon...

fippo commented 9 years ago

so... how did

var getUserMedia = navigator.getUserMedia || navigator.webkitGetUserMedia || navigator.msGetUserMedia || navigator.mozGetUserMedia;

work?

tommoor commented 9 years ago

Have a look at the highlighting of navigator here:

https://github.com/HenrikJoreteg/webrtcsupport/blob/master/index-browser.js

the new 'navigator' isn't highlighted - It's a cyrillic 'i'

fippo commented 9 years ago

UTF8-madness...

fippo commented 9 years ago

ok, updated versions are out