search

HenrikJoreteg / webrtcsupport

Browser module to detect support for WebRTC and extract proper constructors.
55 stars 33 forks source link

better checking for support of data channel #22

Closed xdumaine closed 8 years ago

xdumaine commented 8 years ago

Resolves #21 @fippo

fippo commented 8 years ago

i still don't understand where you are not seeing createDataChannel on the prototype. Instantiating a peerconnection is something i'd prefer to avoid

xdumaine commented 8 years ago

Looks like it's because of adapter.js the RTCPeerConnection added to window does not have createDataChannel on the prototype. Someone mentioned it was deprecated, is that accurate? @fippo Open https://webrtc.github.io/samples/src/content/peerconnection/pc1/ and run window.RTCPeerConnection.prototype.createDataChannel in the console - undefined.

fippo commented 8 years ago

ah... adapter wraps RTCPeerConnection in a way which breaks this. Might be quite some effort to fix that... hm.

But 2/3 browsers support the datachannel, this module is a thing of the past.

createDataChannel is still a thing AFAIK

xdumaine commented 8 years ago

I'm fine with closing these then. It's an issue with adapter, if at all.