HenriquesLab / ZeroCostDL4Mic

ZeroCostDL4Mic: A Google Colab based no-cost toolbox to explore Deep-Learning in Microscopy
MIT License
566 stars 130 forks source link

amend jitclass import from numba in Cellpose notebook #214

Closed LiorPytowski closed 1 year ago

LiorPytowski commented 2 years ago

Hi,

I updated the numba imports for section 6.2 (3D predictions) because jitclass needs to be imported from numba.experimental otherwise we get the error message below:


ImportError Traceback (most recent call last)

in ----> 1 from numba import jitclass, float64 2 from numba import jit ImportError: cannot import name 'jitclass' from 'numba' (/usr/local/lib/python3.7/dist-packages/numba/__init__.py) --------------------------------------------------------------------------- Also, the Anisotropy explanation says that the default value is 1 but by default the value was set to 2, so I set it to 1. Thanks a lot =)
LiorPytowski commented 1 year ago

Hi @guijacquemet ,

Is there anything I can do to help with this pull request?

Note that I believe that there is now another independent issue with the Cellpose Notebook (sections 5.2, 6.1 & 6.2) TypeError: imwrite() got an unexpected keyword argument 'compress'

Thanks a lot

guijacquemet commented 1 year ago

Hi @LiorPytowski , Thanks for tagging me and for the fix. I did not see your PR. I have now fixed both issues in the latest update! Cheers Guillaume