score_combn_batch leads to error

[JH1606-code]

Hi,

I have run the vignettes from github and also procedure 3 from the paper. Everything works great until I run "score_combn_batch". Then for the dataset from the vignettes (Cas9 vs. Cas12a) this error comes:

Error in (function (..., row.names = NULL, check.rows = FALSE, check.names = TRUE, : arguments imply differing number of rows: 8, 0

And also for the dataset "dede_input" I get an error:

_Error in [[<-.data.frame(*tmp*, i, value = c(-0.621976256499478, -0.249371101409029, : replacement has 18 rows, data has 9 In addition: Warning message: In single_gene2[["orient1_id1"]] %in% combn_vals[["orient2id1"]] | : longer object length is not a multiple of shorter object length

I would be happy about a feedback!

Thanks!

[dierckxt]

I'm encountering the same problem.

The problem can be traced down to the score_combn_vc_single function that is called within the score_combn_batch function. There, the argument subset_to_matching_guide_id is used, which isn't present in the batch function call. When the subset_to_matching_ids is called, you end up with the Warning: longer object length is not a multiple of shorter object length call which eventually leads to the issue we encounter, I think. Similarly, the _single function expects a screen_names argument which in the batch function is called condition.

That said, I also point out that the help for the score_combn_vc_single function doesn't reflect the score_combn_vc_single function on multiple counts.