search

Herb-AI / HerbBenchmarks.jl

Benchmarks and problems for Herb.jl
https://herb-ai.github.io/
MIT License
1 stars 0 forks source link

Migrate to `HerbSpecification.jl` #22

Closed ReubenJ closed 6 months ago

ReubenJ commented 6 months ago

HerbData.jl has been deprecated in favor of HerbSpecification.jl. I've updated the benchmarks to use the new Problem type that includes a problem name field and arrays of IOExamples instead of Examples for the problem specification.

Closes #9 and #16.

The package will not precompile, and tests won't pass until https://github.com/Herb-AI/HerbGrammar.jl/pull/54 is merged (and released, I guess?), thus, the draft PR.

The refactor I needed to do involved more than renaming symbols (I had to copy the variable name for each problem to the name field of the constructor), so I scripted it. In case anyone wants to take a peak, the script is in a branch here.

THinnerichs commented 6 months ago

Hijacking the PR to update to HerbGrammar=0.2.0 and HerbCore=0.2.0 conventions. Grammar -> AbstractGrammar

ReubenJ commented 6 months ago

Sorry, ironically made a mess of this PR by rebasing/cleaning up commits. It's now rebased on dev to reflect the changes from #15. Should be ready for review/merge @THinnerichs

THinnerichs commented 6 months ago

I will re-add the formatting we had, i.e. new line for each IOExample.