Closed ReubenJ closed 6 months ago
Hijacking the PR to update to HerbGrammar=0.2.0
and HerbCore=0.2.0
conventions.
Grammar
-> AbstractGrammar
Sorry, ironically made a mess of this PR by rebasing/cleaning up commits. It's now rebased on dev to reflect the changes from #15. Should be ready for review/merge @THinnerichs
I will re-add the formatting we had, i.e. new line for each IOExample.
HerbData.jl
has been deprecated in favor ofHerbSpecification.jl
. I've updated the benchmarks to use the newProblem
type that includes a problem name field and arrays ofIOExample
s instead ofExample
s for the problem specification.Closes #9 and #16.
The package will not precompile, and tests won't pass until https://github.com/Herb-AI/HerbGrammar.jl/pull/54 is merged (and released, I guess?), thus, the draft PR.
The refactor I needed to do involved more than renaming symbols (I had to copy the variable name for each problem to the name field of the constructor), so I scripted it. In case anyone wants to take a peak, the script is in a branch here.