Closed ReubenJ closed 4 months ago
Attention: Patch coverage is 0%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 46.10%. Comparing base (
aca61f9
) to head (0f92127
).
Files | Patch % | Lines |
---|---|---|
src/nodelocation.jl | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
As @nicolaefilat said: Your change is valid.
However, with the current implementation you cannot substitute the entire tree with a hole, if I am not mistaken.
This would be possible when constricting to RuleNodes
specifically.
This is missing a test, which, if we had it, would show that Hole
s do not have an ind
field. Add a new method for Hole
s instead.
Closing in favor of releasing on v0.2.x
branch
Currently, restricting to concrete
RuleNode
s restricts the user from inserting aHole
, for example.