Closed To5BG closed 3 months ago
Attention: Patch coverage is 66.66667%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 46.10%. Comparing base (
aca61f9
) to head (93bec01
).
Files | Patch % | Lines |
---|---|---|
src/rulenode_operators.jl | 66.66% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This looks fine to me, the original _val
feature is not used anywhere. Shall we merge it without @Whebon's approval, as he is probably recovering after his defence? :)
The original _val
is not used anymore, making these checks are redundant. It seems like you have a new use-case for the _val
field (otherwise the check returns false). Maybe we should add a docstring to RuleNode
to clarify what _val
is supposed to do and what format it is expected to be in.
Remove
hasdynamicvalue
function calls from rulenode2expr functions because they cause issues with using_val
as an evaluation cache for the Probe algorithm.