Closed kwasielewski closed 2 months ago
thank you for the fix! this makes sense; it is a case we have overlooked.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 45.95%. Comparing base (
ce15a3a
) to head (1330d9c
). Report is 2 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Makes sense to me, too, @kwasielewski. Thanks for the contribution! Before we merge, can you add a test for this?
Also, I would like to get @THinnerichs' input, as I think we discussed this change at some point and held off on it for some reason. Now I can't remember why.
I added a testset for this change
This PR add an extra check to ensure that the rule is skipped only if both lhs and rhs together are already present in the grammar.
Minimal example of a grammar affected by the change:
Previously rule
B = 1
would be skipped.