HerbCaudill / jsonschema2graphql

Convert JSON schema to GraphQL types
MIT License
44 stars 16 forks source link

Bug fix: Prevent enum value namespace collisions #1

Closed gnidan closed 4 years ago

gnidan commented 5 years ago

Bug fix

Certain enum values collide with JS's object namespace, e.g. "constructor"

Only actual comparator values are identified as comparators.

HerbCaudill commented 5 years ago

Good catch, thanks for this PR!

Could you add a simple test or two to support the change?

gnidan commented 5 years ago

@HerbCaudill how's that?

HerbCaudill commented 4 years ago

@gnidan - thanks again for this. Better late than never, I hope! 😬