search

HerculesWS / Hercules

Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.
http://herc.ws
GNU General Public License v3.0
900 stars 758 forks source link

Skills that go through walls but shouldn't #1175

Open AnisotropicDefixation opened 8 years ago

AnisotropicDefixation commented 8 years ago

RK_WINDCUTTER RK_IGNITIONBREAK RK_DRAGONBREATH RK_DRAGONBREATH_WATER NC_COLDSLOWER WL_COMET WL_EARTHSTRAIN WL_CRIMSONROCK WL_CHAINLIGHTNING WL_FROSTMISTY

AnisotropicDefixation commented 8 years ago

Feel free to add missing skills.

Playtester commented 8 years ago

Are there even any player-casted damage skills that actually go through walls at all on official servers?

AnisotropicDefixation commented 8 years ago

I'm not sure, but about everything does on emulators.

Playtester commented 8 years ago

Yeah it's one of the biggest problems on emulator imo, it's also really bad to add these checks for every single skill individually rather than just implement the common rule.

I investigated this for rAthena too, you can read what I found here: https://github.com/rathena/rathena/issues/937#issue-129856301 (I summarized everything in the first post.)

AnisotropicDefixation commented 8 years ago

Sadly, foreachinshootrange doesn't work properly for certain skills.

Rytech2 commented 8 years ago

Bumping this up so ill remember to check into this,

Playtester commented 8 years ago

Related rAthena commit: https://github.com/rathena/rathena/commit/7906f0a3ff3742bb519b19b0cadbca9db0d35b32

Note: I only checked and fixed the skills mentioned in the commit message. I didn't have the time to test and fix all the 3rd class skills.

On a sidenote, Dragon Breath and Arrow Shower are different from all the other skills in that they can actually hit through walls if it's a one-tile wall and you target the wall directly. This is proof that they can't be unit skills as units couldn't be placed on walls. Compare to Thunder Storm which doesn't hit at all when you cast it on a wall.