search

HerculesWS / Hercules

Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.
http://herc.ws
GNU General Public License v3.0
889 stars 756 forks source link

rA Merges #1234

Open dastgirp opened 8 years ago

dastgirp commented 8 years ago

I am just gathering commits, so that it's easy to track it down and merge (and get inputs from others)

rA commits to be merged:

Anyone is welcomed to list more commits List can be expanded/edited

dastgirp commented 8 years ago

@Jedzkie @Michieru @kyeme

^ Any Comments upon this?

List can be expanded/edited

dastgirp commented 8 years ago

Need confirmation whether this happen with us:

@Jedzkie

List can be expanded/edited

dastgirp commented 8 years ago

Need to be discussed whether this should be merged

kyeme commented 8 years ago

Robe Disappearing I can't reproduce using 2015-05-13client

kyeme commented 8 years ago

Duel Exploit - rathena/rathena@c6ed8a4 Is this it? https://github.com/HerculesWS/Hercules/commit/aa9360cf69c30d26d7333b0c6c952b02b99bcba1

dastgirp commented 8 years ago

@kyeme, it's something different, it would clear all units(by skills) casted by players while entering/leaving the dual. Here's what playtester quoted

The atcommand "duel" changes what kind of "target" you are for others, so you are basically brought to a different plane with it. It is quite similar to moving maps, yet it's lacking all the processing that should come at changing maps like removing ground effects, stopping timerskills and checking the units you leave and enter.

This allows for huge exploits as you can completely mess up the server processing. I won't go into details here, but it allows you to get certain buffs and invincibilities pratically forever
malufett commented 8 years ago

Damage against Skills -we already have this..and as I remember kyeme help me to list skills that hit ground skills...

Decrease Agi -I don't know where they get there sources but according to aegis mdef doesn't have any factor to adoramus effect

overall if its regarding skills and re mechanics I totally do not trust there sources..

Playtester commented 8 years ago

My "sources" are always from testing on Aegis myself, don't really trust external resources. Also you need to look into the linked issue to see what I actually tested. I always document all my tests.

Regard Duel Exploit: Herc already had this fixed by making duel not being affected by effects that effect "all", so it would not be exploitable with dances, safety wall and pneuma anymore. But I still recommend to just treat @duel just like you treat moving on a cell or changing maps and check all the new and ending effects at that point.

Regarding Decrease Agi: Hmm looking at the related issue I created: https://github.com/rathena/rathena/issues/1067 I did test this with Decrease Agi, but I'm not sure if I tested Adoramus vs MDEF anymore. Didn't write it in the issue! Would warrant another check.

malufett commented 8 years ago

I understand....according to this there is no mdef associated with the chances... image

Playtester commented 8 years ago

v5[25].baseclass_0.m_skillName.baseclass_0 is supposed to be job level then? Kinda weird.

I still want to test ingame to make sure, though.

MishimaHaruna commented 8 years ago

Erm, what's this->baseclass_0.baseclass_0.baseclass_0? Can the structs/class definitions there be trusted at all?

malufett commented 8 years ago

@Playtester @MishimaHaruna "v5[25].baseclass_0.m_skillName.baseclass_0" yes it is the base job level "this->baseclass_0.baseclass_0.baseclass_0" it is the class for target or the once casted with adoramus..

I just did a quick peek so some variables are not well named or organized..but the process or programming flow is the same...if master Yommy <3 will be the one doing this it is more cleaner to look..:)

hemagx commented 8 years ago

@malufett function name please? i will check it.

Playtester commented 8 years ago

Tested Adoramus Level 1, Job Level 50: vs 0 Mdef: 6/20 succses vs 50 Mdef: 8/20 success

MDEF clearly doesn't reduce the chance, will correct that on rA. It's wrong on Herc too.

Playtester commented 8 years ago

Here you go: https://github.com/rathena/rathena/commit/1812fddc2936e76e6a07fc01985dec9405c6d402

malufett commented 8 years ago

@hemagx CPC::AB_ADORAMUS() btw can you share to me your IDA options..:)

hemagx commented 8 years ago

I just use ida6.1 nothing special Will check after I finish rescue my old hard disk

On Thu, Mar 31, 2016 at 01:24 malufett notifications@github.com wrote:

@hemagx https://github.com/hemagx CPC::AB_ADORAMUS() btw can you share to me your IDA options..:)

— You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub https://github.com/HerculesWS/Hercules/issues/1234#issuecomment-203679505

hemagx commented 8 years ago 
if ( GetServerRandom(0, 20000) % 100 < this->m_characterInfo.joblevel / 2 + 4 * in_skilldata->skLevel )

so i believe it's correct. :) no mdef associated

kyeme commented 8 years ago

@dastgir issue https://github.com/HerculesWS/Hercules/issues/841

https://github.com/rathena/rathena/issues/984

FlippAcademy commented 7 years ago

Checked off the ASPD Bonus because it seems we already have it https://github.com/HerculesWS/Hercules/blob/master/src/map/status.c#L6130

Thanks for the help @Asheraf