Level 48 Decrease Agi duration - Githubissues

HerculesWS / Hercules

Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.

http://herc.ws

GNU General Public License v3.0

903 stars 757 forks source link

Level 48 Decrease Agi duration #154

Open MishimaHaruna opened 11 years ago

MishimaHaruna commented 11 years ago

Commits to consider:

a4b7719bde71b7fa82a2fcebb9084a3dafb1dc5c: - When bosses use level 48 decrease agi, it will now have a base duration of 65 seconds on players (bugreport:5085)

shennetsind commented 11 years ago

I've run this over aegis, it uses the duration of lvl 10 (which is 65).

shennetsind commented 11 years ago

[21:54:50] <~Ind> the a4b7719 commit says 65 in comment
[21:55:00] <~Ind> but in the file its 130 seconds (aka the 2min and 10 from the aegis screenshot i took earlier)

shennetsind commented 11 years ago

^besides that, the lvl 10 uses 130 so we're good regardless.

shennetsind commented 11 years ago

actually not good, there is this

    case SC_DEC_AGI:
    case SC_ADORAMUS: //Arch Bishop
        if (sd) tick>>=1; //Half duration for players.

rathena's also has this which means on their end its not like this either

        case SC_DECREASEAGI:
        case SC_ADORAMUS: //Arch Bishop
            if (sd) tick>>=1; //Half duration for players.
            sc_def = status->mdef*100;
            tick_def = 0; //No duration reduction
            break;

shennetsind commented 11 years ago

status:pending, awaits the tick update

MishimaHaruna commented 10 years ago

What's the status on this? I lost track of whether it was fixed or not in the end :x

shennetsind commented 10 years ago

the data for this is now available in int status_get_sc_def(struct block_list *src, struct block_list *bl, enum sc_type type, int rate, int tick, int flag) however I don't seem to recall why we needed it (from the looks of it this still hasn't been fixed)