Bad interaction with multi-area headgears and costumes

[bWolfie]

Issue Prelude

• [x] I have not modified the source prior to reproducing this issue.
• [x] I am using the latest version of Hercules.
• [x] I am aware that this report will be closed or deleted if it becomes obvious that I am stating the false.

Description

When you equip a normal headgear that covers more than one slot, then also equip a costume, sometimes there is inconsistent behaviors. Sometimes the costume sprite will override the normal sprite, while others can show both normal and costume at the same time.

Behavior

Example 1: Equip Hat of the Sun God [Upp+Mid] and Costume Sunglasses [cMid]: https://i.imgur.com/ugVc5bD.png Observed: Both sprites are showing. Expected: Hat of the Sun God should not show, as Costume Sunglasses will override.

Example 2: Equip Mr Smile [Mid+Low] and Costume Sunglasses [cMid]: https://i.imgur.com/FOLctYb.png Observed: cMid (Costume Sunglasses) are overriding the Mr Smile. Expected: cMid (Costume Glasses) should override Mr Smile.

Example 3: Equip Sphinx Hat [Upp+Low] and Costume Romantic Leaf [cLow]: https://i.imgur.com/3oWgXMt.png Observed: Both sprites are showing. Expected: Only the Costume Romantic Leaf should show. Note: in this example I made a mistake and left Costume Sunglasses on.

Example 4: Equip Mr Smile [Mid+Low] and Costume Sphinx Hat [cUpp+cLow]: https://i.imgur.com/JA9tvpd.png Observed: Both sprites are showing. Expected: Only the Costume Sphinx Hat should show.

Expected Behavior

I don't know what the official behavior is, but shouldn't the costume always take priority? If it's not official behavior, then we should add a battleconf option for it.

Branch(es):

• [x] master
• [x] stable

[marcosbucarte]

I confirm this, I found it odd because it happened the same with me I thought it would be client problem.

@4144 Could you confirm?