search

HerculesWS / Hercules

Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.
http://herc.ws
GNU General Public License v3.0
902 stars 758 forks source link

"AUTHORS" FILE #245

Closed shennetsind closed 4 years ago

shennetsind commented 10 years ago

Discussion originally started in #226 i'm moving it into a issue so that it doesn't count as a pull request (since its not one anymore). I'll repost the original messages by date below.

shennetsind commented 10 years ago

"I find it confusing how some entries in the authors list use their display name instead of the commit username, I'd propose using either only the username (since its referenced in all their commits, whereas display name isn't anywhere) or both." - Ind

shennetsind commented 10 years ago

"Potentially both names? Forum (IRC, since they're potentially the same) & commit name? shennetsind | Ind" - Streusel

shennetsind commented 10 years ago

"if IRC will be added i suggest to use mailmap format

<cto@company.xx>                       <cto@coompany.xx>
Some Dude <some@dude.xx>         nick1 <bugs@company.xx>
Other Author <other@author.xx>   nick2 <bugs@company.xx>
Other Author <other@author.xx>         <nick2@company.xx>

" - @MrKeiKun

shennetsind commented 10 years ago

"Against awkward email@email.com" - @Streusel

shennetsind commented 10 years ago

"Nothing wrong with using emails, as long as they are already used in commit messages, or somewhere in the code." - @MishimaHaruna

kisuka commented 10 years ago

The issue is that some of the developers in the AUTHORS file are from so long ago that it's hard to find any email for them. Some of the developers also contributed anonymously. There weren't always commit author names, just handles from an old BBS of developers passing around their updated builds.

I'm all for making sure credit is given but we also shouldn't be cluttering up the file too much.

MishimaHaruna commented 10 years ago

This is the file format I was thinking of: https://github.com/django/django/blob/master/AUTHORS (ignore the top part with full names, since it wouldn't work for us, skip to line 58+)

Entries take one of these forms, depending on what info is available:

Author Name (AuthorNickname) <author_email@example.com>
Author Name <author_email@example.com>
AuthorNickname <author_email@example.com>
Author Name (AuthorNickname)
Author Name Only
AuthorNicknameOnly
<author_email_only@example.com>
Streusel commented 10 years ago

Looks good

shennetsind commented 10 years ago

I ran a quicklookup on the git data (which has eathena and rathena data as well, up to the point of respective forks), that might help with the usernames, it also counts each time one is available (case sensitive)

skotlex - 1759
shennetsind - 1562
Playtester - 1121
ultramage - 896
L0ne_W0lf - 688
Lupus - 563
ai4rei - 378
celest - 320
Lance - 296
FlavioJS - 246
brianluau - 241
zephyrus - 217
euphyy - 216
amber - 211
Haru - 189
Inkfish - 185
toms - 157
Paradox924X - 149
MasterOfMuppets - 125
(no author) - 119
shadowlady - 102
kenpachi2k11 - 102
codemaster - 98
rud0lp20 - 96
Streusel - 95
Vicious - 90
malufett - 90
glighta - 88
masao87 - 85
gepard1984 - 83
Kisuka - 77
samuray22 - 74
Kevin - 68
eathenabot - 68
shadow - 68
mc_cameri - 65
momacabu - 64
evera - 64
SinSloth - 62
j-tkay - 61
epoque11 - 58
DracoRPG - 51
Matheus Macabu - 48
Hercules.ws - 47
flaviojs - 42
sketchyphoenix - 42
littlewolf - 40
Gepard - 38
daegaladh - 36
jmanfffreak - 36
eaac - 35
lemongrass3110 - 33
ajarn - 32
xantara - 32
wizputer - 31
akinari1087 - 31
greenboxal2 - 31
Nasedo - 30
valaris - 30
playtester - 28
Mysteries - 28
protimus - 28
blackhole89 - 28
akrus - 26
Poki#3 - 25
cookiecrumbs - 25
Komurka - 25
blacksirius - 25
Zido - 24
markzd - 23
xazax-hun - 23
flaid - 21
Piotr Hałaczkiewicz - 21
aleos - 21
musashiden - 19
lordttseven - 19
jaBote - 16
og2 - 16
calciumkid - 16
Aria - 16
reddozen - 16
KarLaeda - 15
Zephiris - 15
Susu - 15
thatakkarin - 14
DZeroX - 14
ignizh - 13
ediejohnny - 13
shinomori - 12
kobra_k88 - 12
Euphy - 11
Valaris - 11
spre123 - 11
technote24 - 11
Skotlex - 11
LuzZza - 11
Yommy - 11
shadoweathena - 10
Matias - 10
nsstrunks - 10
Chilly0123 - 10
mandark022 - 9
script-z3r0 - 9
shenhuyong - 9
Sara - 8
tr0n93 - 8
Mass - 8
Sirius - 8
nana - 8
Kargha - 8
jtynne - 7
Haruna - 7
veider - 7
mercurial123 - 6
GodLesZ - 6
Dastgir Pojee - 6
Mumbles - 6
cannelle - 6
Shinigami - 6
arcshiru - 5
Paradox924x - 5
foruken - 5
Taylor Locke - 5
davidsiaw - 5
sirius - 5
Kenpachi - 4
hipsterfont - 4
Masao - 4
Shido - 4
Trojal - 4
sevenzz23 - 4
Flipp - 4
Mysterious - 4
Euph - 3
Kayla - 3
rikimaru17 - 3
CairoLee - 3
Akkarinage - 3
M45T3Ryu - 3
Wolf - 3
Earisu - 3
trojal - 3
killercube - 2
Evera - 2
dastgirpojee - 2
Jonathan Lima - 2
Michieru - 2
cleaverbeaver - 2
Xantara - 2
salepate - 2
L0neW0lf.eAthena - 2
Patskie - 2
spira - 2
Masao87 - 1
Mr.Postman - 1
ossi0110 - 1
Mhalicot - 1
Jedzkie - 1
EPuncker - 1
Amir El Sayed - 1
rathenabot - 1
lmaatl - 1
CIA-2 - 1
Guilherme - 1
Protimus - 1
script-Z3R0 - 1
SketchyPhoenix - 1
flaviojs2005 - 1
Jose Luis Rivera Flores - 1
Marcelo Liberato - 1
HerculesUser - 1
Shaktoh - 1
zapbomb - 1
Christian - 1
zido - 1
baalberith - 1
LiYu - 1
jaBote commented 10 years ago

You can safely remove HerculesUser if you want. It was me doing a sample pull request.

P.S.: Didn't know I had that many commits :O

kisuka commented 10 years ago

That seems fine to me @MishimaHaruna.

There will be a lot that will be nickname only as most the jA devs never gave out their email, cuz well.. Japan.

Streusel commented 10 years ago

Can this be closed?