search

HerculesWS / Hercules

Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.
http://herc.ws
GNU General Public License v3.0
900 stars 758 forks source link

New Bargain Sale #2753

Open xBeret opened 4 years ago

xBeret commented 4 years ago

Is your feature request related to a problem? Please describe. None

Describe the solution you'd like None Describe alternatives you've considered None

Additional context Kro recently implemented the new bargain sale for the new Cash Shop.

Below the image of an item for sale at the Cash Shop

cash_shop

Jedzkie commented 4 years ago

@xBeret do you have the packets already?

xBeret commented 4 years ago

@Jedzkie not yet, I think 4144 must have

4144 commented 4 years ago

cash shop need some rework, after i think this sales can be added too. yes i have packets. i think all except one, already in hercules.

Lemongrass3110 commented 4 years ago

It is not really new. Just a little update it seems.

Lemongrass3110 commented 4 years ago

See #2329 and #2613

SombraRO commented 11 months ago

@csnv @guilherme-gm

Looking at some old posts, I think it is necessary to implement them in Hercules, since rathena already has these updates

guilherme-gm commented 11 months ago

@SombraRO Uh, I am not sure why I'm being tagged on this issue. But, I don't have any plans on working on this anytime soon, if ever. I am not part of the staff either, but I think I could say "you may feel free to go ahead and PR it" :)

I agree with 4144 that cashshop needs some rework. I remember everything is in clif right now.

csnv commented 11 months ago

I'm also not part of the staff though 😅 and this issue seems to also require some refactoring that the staff has in consideration and I'm not really aware of.