Closed guilherme-gm closed 8 months ago
I think this is ready for a real review, I made all the PRs up to the end of 2nd classes.
I am not sure whether we should move this to master or put it in an "accumulation" branch until we have all the other PRs (and also the part for transclasses that I didn't make) merged.
A few skills from Transclass bard/dancer may not play well with #3279
I created a new rebalance
and retargeted this PR to that branch. I'll keep the branch up to date with master while the rebalance PRs are under review, and we'll merge it into master once the game is again self-consistent.
This will allow anyone that feels like trying a preview of the (already reviewed and merged) rebalance changes to check out that branch, without disrupting those that rely on the stable version to be stable.
I'll make a mention of this in the main release notes for the 2024.03 release I'm about to sign off
Pull Request Prelude
Changes Proposed
Introduces the rebalance of the first jobs skills. This change affects Renewal-only.
On official servers this came along with rebalances of 2nd jobs and transclass too. I am working in additional PRs for the 2nd jobs, being in separate PRs in order to keep those PRs in a reasonable size.
The implementation in this PR is based on kRO and kRO zero patch notes, iRO Wiki, rAthena and divine pride info, along with some in-game testing. I can't say everything is 100% accurate because there were discrepancies between different sources, and I could not test everything in kRO, but should be quite close.
I won't list all the changes in the PR description, but it may be checked in each commit text. Also, the commits are in the same order as they appear in the references below.
Affected jobs/skills
References:
Issues addressed: Closes #2725