Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.
[x] I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.
Changes Proposed
SC_AUTOSPELL val1 should be the AutoSpell skill level, not the selected skill learned level. This was broken during the refactor (#3237) and is now fixed.
Since it was now using the learned level of the selected skill, this lead to cases where switching the selected skill wouldn't work. For example, if you had Fire Bolt Lv10 and Earth Spikes Lv5 (their max), Lv5 would always be less than Lv10, and would be blocked by the default block of every SC (in status.c, which prevents a lower val1 from overriding a higher val1).
Pull Request Prelude
Changes Proposed
SC_AUTOSPELL val1 should be the AutoSpell skill level, not the selected skill learned level. This was broken during the refactor (#3237) and is now fixed.
Thanks to @violent01 for spotting the issue in the rebalance PR ( https://github.com/HerculesWS/Hercules/pull/3230#issuecomment-1941227650 )
Since it was now using the learned level of the selected skill, this lead to cases where switching the selected skill wouldn't work. For example, if you had Fire Bolt Lv10 and Earth Spikes Lv5 (their max), Lv5 would always be less than Lv10, and would be blocked by the default block of every SC (in status.c, which prevents a lower val1 from overriding a higher val1).
Issues addressed: None