search

HerculesWS / Hercules

Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.
http://herc.ws
GNU General Public License v3.0
903 stars 757 forks source link

Auto Shadow Spell Nullpo Error #3286

Closed bWolfie closed 6 months ago

bWolfie commented 8 months ago

Describe the bug Nullpo error when using Auto Shadow Spell skill. Hoping someone can reproduce.

To Reproduce Steps to reproduce the behavior:

  1. Use Auto Shadow Spell.
  2. Click cancel or ok without selecting a skill.

Expected behavior Skill should not trigger nullpo error.

Screenshots image

System specs (please complete the following information):

Plugins used or source modifications N/A

Additional context N/A

guilherme-gm commented 8 months ago

I can reproduce it on v2024.03, using 2019-12-24 main.

In my case, I didn't even see the window (maybe I didn't have anything to see). I get a bit different stack:

[Warning]: skill_get_index: skill id '0' is not being handled!
[Error]: --- failed assertion --------------------------------------------
[Error]: skill.c:136: '0' in function `skill_get_index'
[Error]: 0x555948e0fcb1 nullpo_backtrace_print
[Error]:        [redacted]/Hercules/src/common/nullpo.c:77
[Error]: 0x555948e0fdd1 assert_report
[Error]:        [redacted]/Hercules/src/common/nullpo.c:147
[Error]: 0x555948d1e642 skill_get_index
[Error]:        ../map/map.h:136
[Error]: 0x555948d5f15b skill_castend_nodamage_id
[Error]:        ../map/map.h:10449
[Error]: 0x555948d44b10 skill_castend_id
[Error]:        ../map/map.h:6548
[Error]: 0x555948e2298e do_timer
[Error]:        [redacted]/Hercules/src/common/timer.c:498
[Error]: 0x555948e29708 main
[Error]:        [redacted]/Hercules/src/common/core.c:542
[Error]: 0x7faef5395d8f __libc_start_call_main
[Error]:        ../sysdeps/x86/libc-start.c:58
[Error]: 0x7faef5395e3f __libc_start_main_impl
[Error]:        ../sysdeps/nptl/libc_start_call_main.h:392
[Error]: 0x555948a79c54 ???
[Error]:        ???:0
[Error]: 0xffffffffffffffff ???
[Error]:        ???:0
[Error]: --- end failed assertion ----------------------------------------