Add script commands to generate some client <TAGS> - Githubissues

HerculesWS / Hercules

Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.

http://herc.ws

GNU General Public License v3.0

894 stars 754 forks source link

Add script commands to generate some client <TAGS> #3300

Closed guilherme-gm closed 3 months ago

guilherme-gm commented 3 months ago

Pull Request Prelude

[x] I have followed proper Hercules code styling.
[x] I have read and understood the contribution guidelines before making this PR.
[x] I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

This PR adds some script commands which generates strings for client tags:

mesnavigation: General purpose command for <NAVI>;
mesmobspawn: Special command for <NAVI> that opens a window "searching" for a monster -- This is a special behavior in navigation
mesurl: For <URL> tag
mestipbox: For <TIPBOX> tag

Using those commands takes into account client support and tries to fall back to some sensible results when something is not supported.

I decided to make them as script commands instead of Global Functions because:

We keep client-specific logic into clif -- I feel like this is too client specific to be handled by scripts
We can eventually use these from source directly if there is a need

Issues addressed: None, I think