Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.
[x] I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.
Changes Proposed
Ensure that on relog the previously removed plagiarized skill doesn't get re-added.
This was due to failure to clear the remembered cloneskill script variables and such.
As by the comment [Aegis] can't overwrite skill of higher level, but will still remove previously copied skill. this is official behavior, that if you had a plagiarized spell, something would attack you with for example Envenom 3, when you have Envenom 10, you'd then lose the plagiarized spell but not have your higher level Envenom overwritten.
That being said I may consider changing it so that if it tries to copy the same level nothing happens. Or re-check if in Aegis this really will result in the removal as well, in case I missed the == case.
Pull Request Prelude
Changes Proposed
Ensure that on relog the previously removed plagiarized skill doesn't get re-added.
This was due to failure to clear the remembered cloneskill script variables and such.
As by the comment
[Aegis] can't overwrite skill of higher level, but will still remove previously copied skill.this is official behavior, that if you had a plagiarized spell, something would attack you with for example Envenom 3, when you have Envenom 10, you'd then lose the plagiarized spell but not have your higher level Envenom overwritten.That being said I may consider changing it so that if it tries to copy the same level nothing happens. Or re-check if in Aegis this really will result in the removal as well, in case I missed the == case.
Issues addressed: None