HerculesWS / Hercules

Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.
http://herc.ws
GNU General Public License v3.0
900 stars 758 forks source link

Fire Expansion Level 1-4 are not working Properly #627

Open purityz opened 9 years ago

purityz commented 9 years ago

From IroWiki : Information

Level 1: Increases Demonic Fire damage by 50% & increase duration by 10 seconds Level 2: Increases Demonic Fire damage based on caster's INT. Cancels Demonic Fire Level 3: Demonic Fire becomes SmokeScreen which reduces ranged damage and increases evasion Level 4: Demonic Fire becomes Tear Gas, which drains HP, reduces accuracy and evasion Level 5: Activates the highest level of Acid Bomb learned.

Problem :

Level 1: Applies the Increase Damage, does not increase the duration by 10 seconds. Level 2: Does not end the skill, instead deals increased damage on Demonic Fire. Level 3: Ceases the damage done by Demonic Fire but does not turn into Purple Gas. No Flee increase and does not decrease damage in the area. Level 4: Ceases the damage done by Demonic Fire but does not become Gray Smoke: Does not reduce Flee and Hit nor drains HP or forces the use of /cry emote. Level 5: Working as intended.

purityz commented 9 years ago

https://github.com/rathena/rathena/tree/96c768f9b78de65d69887df3600b3173e413e32a

MrKeiKun commented 3 years ago

https://github.com/HerculesWS/Hercules/pull/2920 should fix some of this.