search

HerculesWS / Hercules

Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.
http://herc.ws
GNU General Public License v3.0
889 stars 757 forks source link

pdef2 flag (Ice Pick/Thanatos Card) and critical attacks #851

Open AnisotropicDefixation opened 8 years ago

AnisotropicDefixation commented 8 years ago

Currently the damage of crits is decreased instead.

kontownik commented 8 years ago

it's bugged for years :D and always ignored by devs so don't bother :(

AnisotropicDefixation commented 8 years ago

Maybe someone could help us understand the issue at least? Because all this flag does is increase attack based on target's def, why would it conflict with crits in such a way?

anacondaq commented 8 years ago

@kontownik how it must work? Explain please.

kontownik commented 8 years ago

@anacondaqq well i'm not recent RO player but, high DEF make Ice pick do more dmg (%def to %dmg) then crit hit dmg is ignoring DEF (we talk about hard def, from items not from vit).

I remember bug was years ago - so if you can test this situation with thief class (under weapon perfection aura to be more precise)

  1. Non crit hit (ex. double attack) Ice Pick vs Poring

Cowardice Blade vs Poring

  1. 100% crit chance Ice Pick vs Poring

Cowardice Blade vs Poring

Poring got 0 def so if it will be good then test same thing with Pupa, then please check the numbers.

AnisotropicDefixation commented 8 years ago

Crit doesn't ignore DEF in renewal, it just increases final damage by x1.4.

pengc2010 commented 8 years ago

somewhere above the defense reduction There are some codes to make sure a few skills and cri do not have pdef flag, which means pdef benefits normal attack, but not cri. Looks like it is pre-re setting, since cri ignores def. I do not know how pdef should behave in renewal, but if you want a simple 1.4x damage, remove cri in those code.

AnisotropicDefixation commented 8 years ago

Yeah, this did the trick.