HerculesWS / Hercules

Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.
http://herc.ws
GNU General Public License v3.0
901 stars 758 forks source link

Strange issue with area and splash skills #944

Open AnisotropicDefixation opened 8 years ago

AnisotropicDefixation commented 8 years ago

Right now, some skills trigger the animation for every affected target, saturating the screen and possibly causing performance issues such as fps drops, input delay, etc. Further investigation is needed.

This was introduced with these two commits some time ago:

https://github.com/HerculesWS/Hercules/commit/027f124cbb96bb99d00bc31ad51345024edadf66 https://github.com/HerculesWS/Hercules/commit/aaa82f2f8fb70858048d1e199b40bbb797b9604d

To illustrate this issue better; Make a Rune Knight for example and use Ignition Break or Wind Cutter without any targets in range, the animation is triggered correctly in this case. Now spawn a target in range and use them again, you will notice that the animation is now triggered twice at once, overlapping. Now spawn many targets and try again, the animation will replicate and overlap for every affected target, saturating the screen. This doesn't affect all skills handled under that block though and seems inconsistent.

This might also happen to support skills in some cases.

Playtester commented 8 years ago

I'm not really sure how these two commits could have an effect on what you describe... I know that some client update messed up the skill display though...

In any case, I think this probably needs a list of skills that need to be checked, because it's kind of a skill-by-skill issue.