[RE] Wrong and missing item script list

[zackdreaver]

I've found many wrong and missing renewal item script in herc, according kRO desc and 'Aegis' script :

• [ ] [1282] Krieger_Katar2 = should be crit damage +20% not ignore def rate (kRO and Aegis)
• [ ] [1661] Mental_Destroyer = there is bonus based on refine level (Aegis)
• [ ] [2126] Guyak_Shield = there are no autobonus, only bShortWeaponDamageReturn and bLongWeaponDamageReturn at 5% (kRO)
• [ ] [2274] Ghost_Bandana = missing bonus2 bSubEle,Ele_Ghost,10; (kRO and Aegis)
• [ ] [2936] Recovery_Ring = missing bMaxHP,250; bMaxHPrate,5; and bHealPower2,5; (kRO)
• [ ] [2968] RWC_2012_Pendant = missing bMatkRate,1; (kRO)
• [ ] [2969] RWC_2012Pendant = missing bMatkRate,1; (kRO)
• [ ] [5387] Neko_Mimi_Kafra = missing status effects (kRO and Aegis)
• [ ] [5462] Spiked_Scarf = wrong item script, it's following iRO, should be bBaseAtk,30; and bonus bMaxHPrate,-2; (kRO)
• [ ] [5463] Rainbow_Scarf = wrong item script, it's following iRO, should be bMatk,30; and bMaxSPrate,-2; (kRO)
• [ ] [5467] Helm_Of_Dragoon = wrong item script, it's following euRO, refine level will add bExpAddRace,RC_Dragon (kRO)
• [ ] [5469] Noble_Hat = wrong item script, it's following iRO (kRO)
• [ ] [5497] King_Tiger_Doll_Hat = missing bAddRace,RC_Brute,10; and autobonus (kRO and Aegis)
• [ ] [5579] Wanderer's_Sakkat = should delete bonus bAgi,2; (kRO)
• [ ] [5580] Red_Beret = wrong item script, it's following euRO, should be bAllStats,3; and bMdef,3; (kRO)
• [ ] [5595] Eye_Of_Juno = missing item script (Aegis)
• [ ] [18528] Tare_Neko_Cru = missing item script (kRO)
• [ ] [18540] Evil_Mask = missing bonus2 bSPLossRate,1,2000; (Aegis)
• [ ] [18549] Nabi_Hair_Pin = wrong Aegis name, should be Butterfly_Hairpin, and has wrong script (Aegis)

There are still many wrong and missing item script that I haven't check. if you need english desc for related item, you can check translation I made : iteminfo.lua

[Jedzkie]

@zackdreaver some of the Item effects in renewal are same in pre-re, i'll include pre-renewal also.

[zackdreaver]

• [ ] [2647] Nile_Rose = wrong item script, it's following iRO, should be all stats +5 (kRO)
• [ ] [5254] Deviling_Hat = wrong item script, it's following euRO, should be ATK|MATK +2%, EXP gained+2%, exp gained+1% if refined to +7 (kRO)
• [ ] [12221] Megaphone_ = wrong color, and script need to be updated (Aegis)

[Jedzkie]

@zackdreaver, please do give me info regarding ID#12221, i have 3 aegis special.sc's in my pc but i dont know where to choose the right one.

[zackdreaver]

wow 3 Aegis... I only have two, one is below 2013 (±770 KB) and newer 2014 (878 KB) here is aegis script for 12221 :

event OnConsume:
    var name = PcName
    dialog "Note: Talk into a megaphone to let Midgard hear your voice. ^FF0000Offensive content will not be tolerated.^000000. "
    dlgwritestr
    var str = inputstr
    broadcastserver "FFAF1B" FW_NORMAL 12 0 0 name+" talks into a megaphone : "+ str +""
    close
return

[Jedzkie]

is this also the megaphone's behavior in kRO?

[zackdreaver]

dunno, not kRO player, and iRO has removed this item long time ago, can't test

[Jedzkie]

Maybe we should disregard to change the Megaphone until we get kRO's info.

[hemagx]

How much official the NPC dialog is not matter, neither the megaphone syntax. this is rare case, anyway just use PlayerName: MegaPhoneTalk please define a color and don't let the color undefined, this lead to abuse-able bug in client.

[zackdreaver]

I've made translantion fix for these:

• [ ] [5660] Gryphon_Hat = Wrong item script, should delete bAutoSpell, SA_LIGHTNINGLOADER,1,5; , and add refine bonus +7 AGI +2 (kRO)
• [ ] [18580] Yggdrasil_Crown = Wrong item script, and btw why there is "Gender: 1" ? (kRO)
• [ ] [18602] Watermelon_Slice = There should be no item script (kRO)
• [ ] [18626] Gelato_Hat = There should be no item script (kRO)
• [ ] [18629] B_Desert_Wolf_Hat = Wrong item script (kRO)
• [ ] [18671] Rudolf_Hairband = There should be no item script, as the effect is an event script (kRO)
• [ ] [19026] Egir_Helm_K = Wrong level requirement, should be 40 (kRO)

https://github.com/zackdreaver/ROenglishRE/commit/618e63b8c0bcab51e5e322badf4c323641efe124 I'll include all items in forum too as I promise

[zackdreaver]

• [ ] [5574] Pencil_In_Mouth = It has different "case" on RE and PRE, on PRE Pencil_in_Mouth in AEGIS "Pencil_In_Mouth", thus giving warning on console

[Jedzkie]

@zack, please include if PRE-RE or RE in every item thanks!

[Jedzkie]

@zackdreaver PRE-RE Item description for Rainbow Scarf, do you have one? I Prefered kRO, or Other servers but same as kRO's Description.

[zackdreaver]

Rainbow scarf is always 1% matk bonus, not matk +30 because of renewal (remember how staff matk bonus applied after renewal?)

[Jedzkie]

So, the pre-renewal effect of Rainbow Scarf in our repo is correct?

[zackdreaver]

Yes, based on item desc of pre-renewal twRO (i will follow prere desc from twro instead iRO classic from now)

[zackdreaver]

• [ ] [5286] Pecopeco_Hairband = ASPD +5% , Reduces variable cast time by 5% (kRO and Aegis)

[zackdreaver]

kRO has changed cards 4684 to 4696 's script on Main server. Each of them has different % and skill bonus now.

What you add right now are based on sakray server