merge rAthena's Unit Controller Script Commands

HerculesWS / Hercules

Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.

GNU General Public License v3.0

900 stars 758 forks source link

https://github.com/rathena/rathena/commit/2cee5b6ff1bf53c4ae53bc1278b09ae84b8a0a76 this one commit has a lot of stuffs in it, if wanna break it up, there are

[x] Add *getunittype and update *getmapxy (#871)
[x] extend *monster and *areamonster script command to support array pull twice -> https://github.com/HerculesWS/Hercules/pull/1393 https://github.com/HerculesWS/Hercules/pull/1410 and rejected
[ ] add MD_NORANDOM_WALK and MD_NOCAST_SKILL monster flag
[ ] split *unitstop into *unitstopwalk and *unitstopattack
[ ] extend *unitskilluseid/*unitskillusepos for fixed cast time
[x] *setmobdata/*getmobdata
[x] *setmoblook/*getmoblook
[ ] extend homun/pet/merc/elementals to return GID
[x] setunitdir/getunitdir

and these are missing in rathena but I feel like add in

[ ] *mobattach/*getmasterid script command
[ ] *mobevent script command
[x] *setunitsize/*getunisize (#895) <- I already tried but failed to do it
[ ] *mob_sc_start - UMOB_CANMOVETICK is missing in rathena ??

also means I have to make 13 total pull request before we have ourselves a full capable unit-controller commands like rathena has =/

no way I seriously don't like the way rathena do it all at once its better to split out 1 by 1, do it slowly

when I did that *getunittype script command, I never thought about using existing *getmapxy until I suddenly found out can use *getmapxy to retrieve the coordinate of the monster by using GID and Haru also update all *getmapxy script commands to use UNITTYPE_ constant, I never thought about that before too

if we do it slowly, examine the system part by part, we wont suffer the same fate like rathena rathena *getunittype is fuck up rathena *setunitdata has UMOB_SLAVECPYMSTRMD but doesn't have *mobattach script command rathena UMOB_MAPID return map index, WTF ?? rathena UNPC_DMGIMMUNE <-- isn't npc already immune to attack ?? and some others I find it very ridiculous

wanna know how fuck up rathena system is ? read here http://herc.ws/board/topic/8974-script-command-setmobdata-getmobdata/?p=65553 https://rathena.org/board/topic/103785-add-parameters-for-setunitdata/?p=293176 https://rathena.org/board/topic/104023-setunitdata-parameters-what-are-these-for/

HerculesWS / Hercules

merge rAthena's Unit Controller Script Commands #998