search

HermanMartinus / bearblog

Free, no-nonsense, super fast blogging.
MIT License
2.39k stars 73 forks source link

Custom favicons not working on Safari & Firefox #170

Closed Steellow closed 1 year ago

Steellow commented 1 year ago

Just noticed that favicons aren't working anymore, every blog is showing the default bear favicon

HermanMartinus commented 1 year ago

I assume you're using Safari? It looks like Safari doesn't handle SVG favicons so falls back to the default .ico

They are pulling through for me on Chrome though. Will give this a think

HermanMartinus commented 1 year ago

Looks like this is the case. https://caniuse.com/link-icon-svg

Steellow commented 1 year ago

Using Firefox version 104.0. Seems to be working on Chrome

HermanMartinus commented 1 year ago

Ah, just downloaded Firefox to check. I see what you mean. Will investigate

HermanMartinus commented 1 year ago

Fixed for Firefox in 9f545b7e75049a5542e8d4cff19c81ecd67d4b12

Looking into a workaround for Safari

HermanMartinus commented 1 year ago

Safari currently doesn't support this but is inevitably going to in an upcoming release. I'm going to close this issue as done and at some point it'll just start working on Safari (maybe).