Hermes-Marketing / hermes

destination marketing for greeks
0 stars 1 forks source link

34: Created settings file to store magic variables (company collectio… #35

Closed c0nsy closed 2 months ago

c0nsy commented 2 months ago

Created GET by id endpoint, implemented functionality in core

added a settings file and a way for the team to get the settings in an easy way, importing settings and calling get_settings()

we do this because we will not hardcode magic values in the code base, if they change we just need to update one spot: the settings file

Describe your changes

Endpoint that returns a company record depending on the document id (str).

Issue ticket number and link

34

How to test changes

switch to branch, navigate to fastapi docs, trigger get by id endpoint with a valid id (str). Some valid ones, 0,10,100,2,3...

Checklist before requesting a review