HermesApp / Hermes

Compact macOS Pandora client that doesn’t use Flash
http://hermesapp.org/
MIT License
381 stars 99 forks source link

Last.fm Token expired #242

Closed cmurockstar closed 8 years ago

cmurockstar commented 8 years ago

When i try to connect Hermes to my Last.fm account (fresh install) I see:

Connect application Token expired. Please return to Hermes and try again.

nschimme commented 8 years ago

This bug happens for me as well. If anyone is able to apply for a last.fm account it looks like we just need to update the credentials in this file:

https://github.com/HermesApp/Hermes/blob/803fd39cc06e7244b3ae8f5a11cfcf5298fe8ec0/ImportedSources/FMEngine/FMEngine.h

mizterjones commented 8 years ago

This issue persists.

ginader commented 8 years ago

same problem here.

devkinetic commented 8 years ago

same issue here today

nschimme commented 8 years ago

I updated the source code with a fresh token and it still fails. I think Last.fm is bugged.

devkinetic commented 8 years ago

@nschimme I pulled down your fork and can confirm the same error. I'm no ObjectiveC expert but my best guess is that it's one of two things:

The logic in https://github.com/HermesApp/Hermes/blob/master/Sources/Integration/Scrobbler.m needs refactoring.

A different commit to the repo caused the scrobbler to break, perhaps https://github.com/HermesApp/Hermes/commit/1cee0fab3c36f524ea0b514f07cc2131a676ed52

fritzboyle commented 8 years ago

+1 on this issue. Ive tried several times and fails as described above on the last.fm site, then until I remove the check mark in the app, I continually get a notification for the app "last.fm error: Invalid authentication token supplied"

imtehuber1337 commented 8 years ago

Last.fm is a big one for me and that's all that is needed for me to continue to use hermes.

nriley commented 8 years ago

Figured this one out — nothing to do with the token. Should be fixed in the next version.

nriley commented 8 years ago

For anyone who is experiencing this problem, please try out https://sabi.net/temp/Hermes-1.2.7b1.zip and see if it works for you.

jostyee commented 8 years ago

@nriley Last.fm was okay for me. after upgrading to 1.2.7b1, it complained that token expired without popping up the authorize window. I'd to delete all data of the app in keychain, restart the app, login in pandora and then finally the auth window appears.

nriley commented 8 years ago

Hmm, not good. I think this might be because I changed the token so the session token you had in your keychain no longer corresponded to it. I'll try changing it back to test this case.

imtehuber1337 commented 8 years ago

Good Job, Dude!

[image: Inline image 1]

Played through a song and it scrobbled. I'm now a permanent user!!!

On Sun, May 8, 2016 at 7:11 PM, Nicholas Riley notifications@github.com wrote:

For anyone who is experiencing this problem, please try out https://sabi.net/temp/Hermes-1.2.7b1.zip and see if it works for you.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/HermesApp/Hermes/issues/242#issuecomment-217751905

imtehuber1337 commented 8 years ago

[image: Inline image 1]

On Sun, May 8, 2016 at 11:37 PM, Stephen Carboni Jr. < stephencarboni@gmail.com> wrote:

Good Job, Dude!

Played through a song and it scrobbled. I'm now a permanent user!!!

On Sun, May 8, 2016 at 7:11 PM, Nicholas Riley notifications@github.com wrote:

For anyone who is experiencing this problem, please try out https://sabi.net/temp/Hermes-1.2.7b1.zip and see if it works for you.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/HermesApp/Hermes/issues/242#issuecomment-217751905

nriley commented 8 years ago

@imtehuber1337 — Thanks! (Also, think GitHub is filtering those images, I don't see anything. You probably need to attach them via the Web site rather than email.)

nriley commented 8 years ago

@iyee — it was what I thought; sorry for the oversight. I've fixed your issue and posted a new version which handles Last.fm (https://sabi.net/temp/Hermes-1.2.7b2.zip).

ginader commented 8 years ago

I tried both yesterday's beta as well as today's and they both have the same problem for me: they crash as soon as I have entered my Pandora Password and hit the "sign in" button. I deleted everything named "Hermes" in both Keychain and Library/Application Support without any change.

It did create a plist in the CrashReport folder. Are you're interested in that?

thanks for maintaining this great app! Keep up the good work :-)

On Mon, May 9, 2016 at 8:44 AM, Nicholas Riley notifications@github.com wrote:

@iyee https://github.com/iyee — it was what I thought; sorry for the oversight. I've fixed your issue and posted a new version which handles Last.fm (https://sabi.net/temp/Hermes-1.2.7b2.zip).

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/HermesApp/Hermes/issues/242#issuecomment-217903064

Cheers Dirk

cmurockstar commented 8 years ago

Same for me - quit after entering pandora info. For context, this is a computer that has never had Hermes on it.

nriley commented 8 years ago

@ginader — yes, that would be helpful. I did test the first-launch process on my own Mac and it worked fine, so there must be something different configuration-wise. I may need to audit some other folks' changes that I merged in; I think some may have been a bit…aggressive about their memory use.

ginader commented 8 years ago

hey @nriley here's the crash report: https://gist.github.com/ginader/45218d98c3337fef7c6fbe7de8609333

nriley commented 8 years ago

OK, found the problem — this was a crash that only affected Pandora One members. Give this a shot: https://sabi.net/temp/Hermes-1.2.7b3.zip

ginader commented 8 years ago

Woohoo! It works! Thanks a lot @nriley! Are you accepting tips of any kind? I'd love to send you a little token of my appreciation for your great work :-)

nriley commented 8 years ago

1.2.7 is now released and this problem appears to be fixed for good, I hope! Thanks everyone.