Closed vanrijn closed 8 years ago
Hi,
Thanks for the contribution!
It seems you're basing your pull request on a very old version of Hermes from 2013. The changes you've made have been fixed already in 1f4ddcd. I'd recommend you update to the current version as there have been a lot of changes since then!
(Of course, I only noticed the above after spending an hour trying to figure out why Xcode wasn't giving me deprecation warnings!)
LOL, okay, thanks @nriley. Not sure how this happened, tbh, as I had forked from master. Oh well, thanks for helping to maintain Hermes! I love it! =:)
These small changes allow me to compile Hermes in Xcode 7.3.1, on El Capitan. Thanks!